Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct More Details to agency URL if route URL is unavailable. #1219

Merged
merged 2 commits into from
May 22, 2024
Merged

Direct More Details to agency URL if route URL is unavailable. #1219

merged 2 commits into from
May 22, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented May 21, 2024 •
edited
Loading

Description:
Show the "More details" link in the pattern viewer and direct the user to the agency URL in cases where a route URL is not provded

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

binh-dam-ibigroup
binh-dam-ibigroup approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josh-willis-arcadis
josh-willis-arcadis approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amy-corson-ibigroup amy-corson-ibigroup merged commit 61b6795 into dev May 22, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the show-more-details-in-more-cases branch May 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @binh-dam-ibigroup @josh-willis-arcadis